feat: reconcile policy webhook configurations #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
from
d8925f6
to
6c6021b
Compare
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
from
0c4cdbc
to
4041d1a
Compare
fabriziosestito
commented
Nov 15, 2023
viccuad
reviewed
Nov 16, 2023
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
4 times, most recently
from
64eefa4
to
0909b3f
Compare
jvanz
requested changes
Nov 17, 2023
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
2 times, most recently
from
0118d13
to
84be709
Compare
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
from
6bc7be6
to
7381c5d
Compare
fabriziosestito
commented
Nov 18, 2023
viccuad
reviewed
Nov 20, 2023
viccuad
approved these changes
Nov 20, 2023
…oncile if changed Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
…dmissionPolicy and ClusterAdmissionPolicy controllers Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
…luster using a k3s testcontainer Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
tests Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
force-pushed
the
feat/webhooks-reconciliation
branch
from
4efdcc9
to
12c7b72
Compare
flavio
approved these changes
Nov 21, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes: #224, adding reconciliation of ValidatingWebhookConfiguration and MutatingWebhookConfiguration if those are changed (by the user).
Test
This PR introduces a k3s
testcontainerto test the controllers against a real cluster, by usingenvtest.The
envtestsetup was already there, but not using a real cluster we weren't able to test Kubernetes builtin resources "side-effects", e.g. creating a deployment was not causing a ReplicaSet and Pods to be created. This is because by defaultenvtestspins up a fake control plane with no Kubernetes built-in controllers.Also, we were lacking tests for the admission policies controllers' happy paths. This PR adds them.
NOTE: Webhooks integration tests are still not running against a real cluster, but using
envtestin this case might be overkill.Consider refactoring these tests to unit tests (see: #579)